PR-C0: remove tile.track conditional — consistent border + label on all tiles
- Remove the tile.track ternary from the name label class — use bg-backdrop/80 consistently for all tiles (both video and no-video) - Remove the !tile.track conditional from the border — apply border border-line to all tiles consistently - Fixes shadow rendering inconsistency: with two tiles, the conditional border + ternary caused asymmetric shadow rendering (cropped/pointed shadows) Per review feedback from @matt on PR #3 (forgejo).
This commit is contained in:
parent
928456649e
commit
9e73262cb7
1 changed files with 2 additions and 5 deletions
|
|
@ -221,8 +221,7 @@
|
||||||
{@const media = $mediaStateByIdentity(tile.liveKitIdentity)}
|
{@const media = $mediaStateByIdentity(tile.liveKitIdentity)}
|
||||||
<div
|
<div
|
||||||
class={cx(
|
class={cx(
|
||||||
"relative isolate overflow-hidden rounded-2xl shadow-sm",
|
"relative isolate overflow-hidden rounded-2xl shadow-sm border border-line",
|
||||||
!tile.track && "border border-line border-solid",
|
|
||||||
layout === "spotlight" && "min-h-0 flex-1",
|
layout === "spotlight" && "min-h-0 flex-1",
|
||||||
layout === "default" && "aspect-video w-full min-h-0",
|
layout === "default" && "aspect-video w-full min-h-0",
|
||||||
layout === "strip" && "aspect-video w-44 shrink-0",
|
layout === "strip" && "aspect-video w-44 shrink-0",
|
||||||
|
|
@ -249,9 +248,7 @@
|
||||||
</div>
|
</div>
|
||||||
{/if}
|
{/if}
|
||||||
<span
|
<span
|
||||||
class="pointer-events-none absolute bottom-1 left-1 max-w-[calc(100%-0.5rem)] truncate rounded px-1.5 py-0.5 text-xs {tile.track
|
class="pointer-events-none absolute bottom-1 left-1 max-w-[calc(100%-0.5rem)] truncate rounded bg-backdrop/80 px-1.5 py-0.5 text-xs">
|
||||||
? 'bg-surface/80'
|
|
||||||
: 'bg-backdrop/80'}">
|
|
||||||
{labelFor(tile.liveKitIdentity, tile.source)}{tile.isLocal ? " (you)" : ""}
|
{labelFor(tile.liveKitIdentity, tile.source)}{tile.isLocal ? " (you)" : ""}
|
||||||
</span>
|
</span>
|
||||||
{#if videoTiles.length > 1}
|
{#if videoTiles.length > 1}
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue