PORT: align default to 4738 throughout stack #10

Merged
matt merged 1 commit from mailship-lcy-port-readme-says-default-3000-env-ts-thr-8fe into main 2026-09-14 17:34:37 +00:00
Collaborator

mailship-lcy

Make PORT optional with a single documented default of 4738, matching what every infra file already uses. The README claimed the default was 3000 while env.ts threw if PORT was unset and .env.template, Dockerfile, and docker-compose all used 4738.

Changes

  • src/env.ts — removed the throw guard (PORT is not defined) and replaced it with a console.log warning. The export now falls back to '4738' when PORT is unset, consistent with how EVENT_VIEWER_URL, BRAND_NAME, and BRAND_ACCENT already handle optional vars in the same file.
  • README.md — corrected the documented default from 3000 to 4738 in the PORT row of the configuration table.

No changes needed for .env.template, Dockerfile, or docker-compose.yml — they already specify 4738.

How to test

Start the server without setting PORT in the environment: it should log PORT not set, defaulting to 4738 and listen on port 4738. Start with PORT=3000 to confirm the env override still works.

mailship-lcy Make PORT optional with a single documented default of 4738, matching what every infra file already uses. The README claimed the default was 3000 while env.ts threw if PORT was unset and .env.template, Dockerfile, and docker-compose all used 4738. **Changes** - **src/env.ts** — removed the `throw` guard (`PORT is not defined`) and replaced it with a `console.log` warning. The export now falls back to `'4738'` when `PORT` is unset, consistent with how `EVENT_VIEWER_URL`, `BRAND_NAME`, and `BRAND_ACCENT` already handle optional vars in the same file. - **README.md** — corrected the documented default from `3000` to `4738` in the PORT row of the configuration table. No changes needed for `.env.template`, `Dockerfile`, or `docker-compose.yml` — they already specify `4738`. **How to test** Start the server without setting `PORT` in the environment: it should log `PORT not set, defaulting to 4738` and listen on port 4738. Start with `PORT=3000` to confirm the env override still works.
hudson added 1 commit 2026-09-14 17:16:00 +00:00
- src/env.ts: remove required-PORT throw, default to '4738' when unset
- README.md: change documented default from 3000 to 4738

All other files (.env.template, Dockerfile, docker-compose.yml)
already use 4738 — no further changes needed.
matt merged commit 091fe6e7f3 into main 2026-09-14 17:34:37 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: matt/mailship#10
No description provided.