matt/mailship
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: remove unused/misplaced dependencies (bcrypt, express-ws, ts-node-dev, @types/node) #20

Merged
matt merged 1 commit from mailship-6m4-remove-unused-misplaced-dependencies-bcr-d33 into main 2026-09-18 15:20:46 +00:00
Conversation 0 Commits 1 Files changed 2 +1 -6
hudson commented 2026-09-18 14:33:35 +00:00
Collaborator
Copy link

mailship-6m4

Remove four unused or misplaced dependencies to shrink the supply-chain surface and reduce the production image size.

  • bcrypt (^5.1.1) — no imports anywhere in src/, test/, or scripts/. Entirely unused; removed.
  • express-ws (^5.0.2) — no imports anywhere (server uses plain REST + welshman sockets). Removed along with its orphaned @types/express-ws dev dependency.
  • ts-node-dev (^2.0.0) — deprecated (replaced by tsx), no imports, and was incorrectly placed in dependencies instead of devDependencies. Removed entirely.
  • @types/node (^22.18.1) — moved from dependencies to devDependencies, where type-only packages belong.
  • pnpm.onlyBuiltDependencies — pruned bcrypt from the allowlist since it is no longer a dependency.

How to test: Run pnpm install --frozen-lockfile, pnpm run check (tsc + eslint), pnpm run build, and pnpm test:unit. All 16 unit tests pass.

mailship-6m4 Remove four unused or misplaced dependencies to shrink the supply-chain surface and reduce the production image size. - **`bcrypt`** (^5.1.1) — no imports anywhere in src/, test/, or scripts/. Entirely unused; removed. - **`express-ws`** (^5.0.2) — no imports anywhere (server uses plain REST + welshman sockets). Removed along with its orphaned `@types/express-ws` dev dependency. - **`ts-node-dev`** (^2.0.0) — deprecated (replaced by `tsx`), no imports, and was incorrectly placed in `dependencies` instead of `devDependencies`. Removed entirely. - **`@types/node`** (^22.18.1) — moved from `dependencies` to `devDependencies`, where type-only packages belong. - **`pnpm.onlyBuiltDependencies`** — pruned `bcrypt` from the allowlist since it is no longer a dependency. **How to test:** Run `pnpm install --frozen-lockfile`, `pnpm run check` (tsc + eslint), `pnpm run build`, and `pnpm test:unit`. All 16 unit tests pass.
hudson added 1 commit 2026-09-18 14:33:36 +00:00
Remove unused/misplaced dependencies (bcrypt, express-ws, ts-node-dev, @types/node)
All checks were successful
CI / checks (pull_request) Successful in 48s
Details
3d24260419 
- Remove bcrypt (^5.1.1) — no imports anywhere in source
- Remove express-ws (^5.0.2) — no imports (server uses REST + welshman)
- Remove ts-node-dev (^2.0.0) — deprecated, replaced by tsx, was in deps
- Remove @types/express-ws (dev) — no longer needed without express-ws
- Move @types/node (^22.18.1) from dependencies → devDependencies
- Prune bcrypt from pnpm.onlyBuiltDependencies list

All quality gates pass: tsc --noEmit, eslint, build, and 16 unit tests.
matt approved these changes 2026-09-18 15:20:42 +00:00
matt merged commit 612a4f5af2 into main 2026-09-18 15:20:46 +00:00
matt deleted branch mailship-6m4-remove-unused-misplaced-dependencies-bcr-d33 2026-09-18 15:20:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
matt
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: matt/mailship#20
No description provided.
Delete branch "mailship-6m4-remove-unused-misplaced-dependencies-bcr-d33"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?