Fix broken NIP-9a link in README and document Node/single-instance requirements #21

Merged
matt merged 3 commits from mailship-jh5-readme-nip-9a-link-is-empty-broken-897 into main 2026-09-18 17:11:24 +00:00
Collaborator

mailship-jh5

README had two occurrences of [NIP-9a]() with an empty URL (intro paragraph and the API section header). Also undocumented: the Node >= 22 requirement and the single-instance constraint from in-process cron jobs.

Changes:

  • Replaced both empty NIP-9a links with a link to the canonical NIP-9a spec at https://github.com/nostr-protocol/nips/blob/master/9a.md
  • Added a Requirements: line noting Node >= 22 (needed for crypto.createHash usage in src/server.ts)
  • Added a Single instance: notice that in-process cron jobs mean running more than one instance concurrently may cause duplicate or missed emails

How to test: Render the README — both NIP-9a references are now clickable links pointing to the NIP-9a spec. The Development section shows the Node version requirement and the single-instance note above the setup commands.

mailship-jh5 README had two occurrences of `[NIP-9a]()` with an empty URL (intro paragraph and the API section header). Also undocumented: the Node >= 22 requirement and the single-instance constraint from in-process cron jobs. **Changes:** - Replaced both empty NIP-9a links with a link to the canonical NIP-9a spec at `https://github.com/nostr-protocol/nips/blob/master/9a.md` - Added a **Requirements:** line noting Node >= 22 (needed for `crypto.createHash` usage in `src/server.ts`) - Added a **Single instance:** notice that in-process cron jobs mean running more than one instance concurrently may cause duplicate or missed emails **How to test:** Render the README — both NIP-9a references are now clickable links pointing to the NIP-9a spec. The Development section shows the Node version requirement and the single-instance note above the setup commands.
hudson added 1 commit 2026-09-18 14:33:56 +00:00
fix(README): repair empty NIP-9a links, add Node & single-instance constraints
All checks were successful
CI / checks (pull_request) Successful in 41s
37ec3e8122
- Replace empty NIP-9a URL (first paragraph and API section header)
  with a link to https://github.com/nostr-protocol/nips/blob/master/9a.md
- Add Node >= 22 requirement to Development section
- Add single-instance constraint note about in-process cron jobs
matt reviewed 2026-09-18 15:27:35 +00:00
matt left a comment
Owner

NIP-9a isn't merged yet. Let's link to https://github.com/nostr-protocol/nips/pull/2194 for now.

NIP-9a isn't merged yet. Let's link to https://github.com/nostr-protocol/nips/pull/2194 for now.
matt added 1 commit 2026-09-18 15:27:41 +00:00
Merge branch 'main' into mailship-jh5-readme-nip-9a-link-is-empty-broken-897
All checks were successful
CI / checks (pull_request) Successful in 36s
08a1fd5232
hudson added 1 commit 2026-09-18 16:59:40 +00:00
README: link NIP-9a to the spec PR (2194) — not yet merged to master
All checks were successful
CI / checks (pull_request) Successful in 38s
bcce525a83
matt approved these changes 2026-09-18 17:11:21 +00:00
matt merged commit 7b75b2f4aa into main 2026-09-18 17:11:24 +00:00
matt deleted branch mailship-jh5-readme-nip-9a-link-is-empty-broken-897 2026-09-18 17:11:29 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: matt/mailship#21
No description provided.