matt/mailship
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: replace hardcoded #7161FF with {{brandAccent}} in digest email template #5

Merged
matt merged 2 commits from mailship-hu5-stale-hardcoded-accent-7161ff-in-digest--a31 into main 2026-09-10 19:35:05 +00:00
Conversation 0 Commits 2 Files changed 2 +76 -2
hudson commented 2026-09-10 16:34:28 +00:00
Collaborator
Copy link

mailship-hu5

Summary: Two CSS rules in src/emails/digest.mjml hardcoded #7161FF for the event-item border-left and footer-link color, ignoring the {{brandAccent}} Mustache variable already used by the rest of the template. When BRAND_ACCENT is customized, those two elements stayed the default purple. This fix drives both from {{brandAccent}}.

Changes:

  • src/emails/digest.mjml — replaced #7161FF with {{brandAccent}} in .event-item border-left and .footer a color (2 hunks).
  • test/digest-template.test.js — new failing-turned-passing test with 4 assertions: verifies neither rule contains #7161FF and both reference {{brandAccent}}.

How to test: Run node test/digest-template.test.js — all 4 assertions must pass. To preview the rendered email with a custom accent, set brandAccent in script/render-preview.mjs and run pnpm run preview:digest.

mailship-hu5 **Summary:** Two CSS rules in `src/emails/digest.mjml` hardcoded `#7161FF` for the event-item border-left and footer-link color, ignoring the `{{brandAccent}}` Mustache variable already used by the rest of the template. When `BRAND_ACCENT` is customized, those two elements stayed the default purple. This fix drives both from `{{brandAccent}}`. **Changes:** - `src/emails/digest.mjml` — replaced `#7161FF` with `{{brandAccent}}` in `.event-item` border-left and `.footer a` color (2 hunks). - `test/digest-template.test.js` — new failing-turned-passing test with 4 assertions: verifies neither rule contains `#7161FF` and both reference `{{brandAccent}}`. **How to test:** Run `node test/digest-template.test.js` — all 4 assertions must pass. To preview the rendered email with a custom accent, set `brandAccent` in `script/render-preview.mjs` and run `pnpm run preview:digest`.
hudson added 2 commits 2026-09-10 16:34:29 +00:00 
Lines 8 and 22 of digest.mjml hardcoded #7161FF for the event-item
border-left and footer link color, while mailer.ts already passes
brandAccent into the template (used at lines 15 and 34). When
BRAND_ACCENT is customized, the border and footer links stayed the
default purple.

Drive both from {{brandAccent}} so they respect the customization.

Fixes bead mailship-hu5
matt approved these changes 2026-09-10 19:35:00 +00:00
matt merged commit 93ffdf3531 into main 2026-09-10 19:35:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
matt
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: matt/mailship#5
No description provided.
Delete branch "mailship-hu5-stale-hardcoded-accent-7161ff-in-digest--a31"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?