9fa1f73316
All checks were successful
CI / checks (pull_request) Successful in 36s
Problem
-------
1. Re-clicking an already-confirmed confirmation link (e.g. /confirm?token=…)
returned from confirmSubscription because the SQL WHERE
clause required . The caller then threw an
ActionError('invalid or expired') which rendered the 'Email not confirmed'
error page — misleading for someone who had already confirmed.
2. A second PUT /subscription/email with the same email+frequency could
silently bypass the upsert path when getSubscriptionByPubkey found the
active row but updateSubscription returned it unchanged (email and
frequency matched). While the unique index prevented a true duplicate
INSERT, the code path was fragile and the regression test was missing.
Changes
-------
database.ts:
- confirmSubscription now returns { sub, alreadyConfirmed } | undefined.
First it tries the existing UPDATE (unconfirmed tokens only). If that
returns no rows, it looks up the key directly: if the row exists and is
already confirmed, returns { sub, alreadyConfirmed: true }. If the row
doesn't exist or is unsubscribed, returns undefined (invalid/expired).
- Exported new ConfirmResult type for callers.
actions.ts:
- confirmSubscriptionAction destructures the new return type.
- Only registers the cron job on fresh confirmation (not re-confirms).
- Returns the ConfirmResult so the route can distinguish the two cases.
server.ts:
- /confirm route checks result.alreadyConfirmed and renders
confirm-already.html instead of confirm-success.html.
pages/confirm-already.html:
- New page with title 'Email already confirmed' and an info message
explaining the address was already confirmed.
Tests:
- test/confirm-already-confirmed.test.ts — NEW (3 tests): first confirm
succeeds with alreadyConfirmed=false; second confirm returns
alreadyConfirmed=true; nonexistent token returns undefined.
- test/duplicate-subscription.test.ts — NEW (4 tests): full cycle of
register → confirm → re-register → assert one active row with
unchanged key, verifying the upsert is idempotent.
- Adapted 3 existing test files to destructure the new ConfirmResult.
44 lines
No EOL
1.8 KiB
TypeScript
44 lines
No EOL
1.8 KiB
TypeScript
import { describe, it, expect, beforeAll } from 'vitest'
|
|
import * as db from '../src/database.js'
|
|
|
|
const pubkey = 'reconfirm-test-' + Date.now()
|
|
const email = 'reconfirm-test-' + Date.now() + '@example.com'
|
|
let token: string
|
|
|
|
describe('Confirm link idempotency — already-confirmed token', () => {
|
|
beforeAll(async () => {
|
|
await db.migrate()
|
|
})
|
|
|
|
it('creates and confirms a subscription for the first time', async () => {
|
|
const sub = await db.insertSubscription(pubkey, email, 'daily')
|
|
expect(sub).toBeTruthy()
|
|
token = sub.key
|
|
|
|
const result = await db.confirmSubscription(token)
|
|
expect(result).toBeTruthy()
|
|
expect(result!.sub.confirmed_at).toBeTruthy()
|
|
expect(result!.alreadyConfirmed).toBe(false)
|
|
})
|
|
|
|
it('returns a distinct result (not undefined) when confirming an already-confirmed token', async () => {
|
|
// BUG: confirmSubscription used `WHERE confirmed_at IS NULL`, so
|
|
// re-confirming an already-confirmed token matched zero rows and
|
|
// the UPDATE returned nothing → parseSubscription returned undefined.
|
|
// The caller then threw ActionError('invalid or expired') and the
|
|
// user saw "Email not confirmed" — which is misleading.
|
|
//
|
|
// FIX: confirmSubscription now detects the already-confirmed case
|
|
// and returns { sub, alreadyConfirmed: true } so the handler can
|
|
// render an "already confirmed" info page instead of an error page.
|
|
const result = await db.confirmSubscription(token)
|
|
expect(result).not.toBeUndefined()
|
|
expect(result!.alreadyConfirmed).toBe(true)
|
|
expect(result!.sub.confirmed_at).toBeTruthy()
|
|
})
|
|
|
|
it('returns undefined for a nonexistent token', async () => {
|
|
const result = await db.confirmSubscription('nonexistent-token-' + Date.now())
|
|
expect(result).toBeUndefined()
|
|
})
|
|
}) |